Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make symbol optional #1110

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: make symbol optional #1110

merged 1 commit into from
Jan 22, 2025

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 17, 2025 •
edited
Loading

Fixes snapshot-labs/sx-monorepo#1098

This PR will make the symbol property optional in the space settings (and allow blank VO symbol)

@wa0x6e wa0x6e requested review from ChaituVR and bonustrack January 17, 2025 17:12
@wa0x6e wa0x6e marked this pull request as ready for review January 17, 2025 17:12
@wa0x6e wa0x6e mentioned this pull request Jan 16, 2025
Closed
1 task
bonustrack
bonustrack approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jan 22, 2025

@ChaituVR Could you release on NPM once merged ?

@ChaituVR ChaituVR merged commit cce805b into master Jan 22, 2025
4 checks passed
@ChaituVR ChaituVR deleted the feat-make-symbol-optional-in-space-settings branch January 22, 2025 19:41
@wa0x6e wa0x6e mentioned this pull request Feb 1, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: voting power field in offchain space settings should be mandatory
3 participants
@wa0x6e @bonustrack @ChaituVR